Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forbid use of implicit any #2955

Draft
wants to merge 17 commits into
base: main
Choose a base branch
from
Draft

Forbid use of implicit any #2955

wants to merge 17 commits into from

Conversation

matthieusieben
Copy link
Contributor

@matthieusieben matthieusieben commented Nov 7, 2024

Part of #2999

Using main instead of msi/lex-gen-optimization (#299) as "base branch" to allows CI to run.

The tsconfig currently does not disable the use of "implicit any". This can have harmful side effects as this effectively disables type safety without a way of notifying the developer. This change fixes that.

@matthieusieben matthieusieben marked this pull request as draft November 14, 2024 19:56
@matthieusieben matthieusieben changed the base branch from main to msi/lex-gen-typefixes November 15, 2024 08:11
@matthieusieben matthieusieben force-pushed the msi/ts-implicit-any branch 2 times, most recently from 9a2105d to 4b30d56 Compare November 15, 2024 10:09
@matthieusieben matthieusieben force-pushed the msi/lex-gen-typefixes branch 2 times, most recently from fe5bb04 to 9117a3e Compare November 15, 2024 10:50
@matthieusieben matthieusieben changed the base branch from msi/lex-gen-typefixes to main November 15, 2024 10:53
@matthieusieben matthieusieben force-pushed the msi/ts-implicit-any branch 4 times, most recently from 2e09700 to c4b687d Compare November 15, 2024 13:36
@matthieusieben matthieusieben force-pushed the msi/ts-implicit-any branch 3 times, most recently from a5e7c4f to 0d774bc Compare November 15, 2024 14:21
@matthieusieben matthieusieben force-pushed the msi/lex-gen-typefixes branch 8 times, most recently from 235b34d to ba0dfe5 Compare December 18, 2024 10:17
@matthieusieben matthieusieben force-pushed the msi/lex-gen-typefixes branch 2 times, most recently from e423018 to febe22d Compare January 8, 2025 08:16
@matthieusieben matthieusieben changed the base branch from msi/lex-gen-typefixes to msi/lex-gen-optimization January 8, 2025 08:38
@matthieusieben matthieusieben force-pushed the msi/lex-gen-optimization branch 9 times, most recently from 7fa74c3 to 6630a9b Compare January 13, 2025 18:24
@matthieusieben matthieusieben force-pushed the msi/lex-gen-optimization branch 5 times, most recently from cfa432c to 78c8561 Compare January 27, 2025 00:07
@matthieusieben matthieusieben force-pushed the msi/lex-gen-optimization branch 3 times, most recently from 9c7ee84 to 8e04164 Compare February 6, 2025 15:11
@matthieusieben matthieusieben force-pushed the msi/lex-gen-optimization branch from 6067ace to 4715c89 Compare February 12, 2025 14:01
Base automatically changed from msi/lex-gen-optimization to main February 13, 2025 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant