Improve codegen typings (#2999)

* Make codegen types stricter
* Add .js file extension to import statements in generated code
* Fixes a bug that would clear interests prefs when updating hidden posts prefs.

.changeset/beige-trees-float.md

@@ -0,0 +1,5 @@
+---
+"@atproto/api": patch
+---
+
+Fixes a bug that would clear interests prefs when updating hidden posts

.changeset/brown-flies-stare.md

@@ -0,0 +1,10 @@
+---
+"@atproto/ozone": patch
+"@atproto/bsky": patch
+"@atproto/api": minor
+"@atproto/pds": patch
+---
+
+Update Lexicon derived code to better reflect data typings. In particular, Lexicon derived interfaces will now explicitly include the `$type` property that can be present in the data.
+
+

.changeset/fast-points-walk.md

@@ -0,0 +1,5 @@
+---
+"@atproto/syntax": patch
+---
+
+Improve performance of isValidTid

.changeset/fast-waves-jog.md

@@ -0,0 +1,5 @@
+---
+"@atproto/lex-cli": minor
+---
+
+Update the code generation to better reflect the data typings. In particular this change will cause generated code to explicit the `$type` property that can be present in the data.

.changeset/green-cherries-shave.md

@@ -0,0 +1,5 @@
+---
+"@atproto/pds": patch
+---
+
+Minor typing fixes

.changeset/green-forks-lie.md

@@ -0,0 +1,5 @@
+---
+"@atproto/api": minor
+---
+
+Helper functions (e.g. `NS.isRecord`) no longer casts the output value. Use `asPredicate(NS.validateRecord)` to create a predicate function that will ensure that an unknown value is indeed an `NS.Record`. The `isX` helper function's purpose is to discriminate between `$type`d values from unions.

.changeset/late-worms-travel.md

@@ -0,0 +1,5 @@
+---
+"@atproto/lex-cli": patch
+---
+
+Add `.js` file extension to `import` statements in generated code.

.changeset/popular-shirts-rescue.md

@@ -0,0 +1,5 @@
+---
+"@atproto/lexicon": patch
+---
+
+Various performance improvements

.changeset/shiny-suns-walk.md

@@ -0,0 +1,5 @@
+---
+"@atproto/lex-cli": patch
+---
+
+Type the generated `ids` object (that contains all the lexicon namespace ids) as `const`.

.changeset/silly-starfishes-pay.md

@@ -0,0 +1,5 @@
+---
+"@atproto/lexicon": patch
+---
+
+Fully type `ValidationResult`'s `value` property, allowing `NS.validateMyType` helper functions to return a typed value in case of success.

.changeset/spotty-bottles-march.md

@@ -0,0 +1,5 @@
+---
+"@atproto/lex-cli": minor
+---
+
+Remove `[string]: unknown` index signature from custom user objects, input and output schemas.

.changeset/tiny-carpets-impress.md

@@ -0,0 +1,5 @@
+---
+"@atproto/lex-cli": patch
+---
+
+Ensures that empty `schemas` arrays are typed as `LexiconDoc[]`.

.prettierignore

@@ -6,3 +6,9 @@ pnpm-lock.yaml
 .pnpm*
 .changeset
 CHANGELOG.md
+
+# Prettier is used to format the code during codegen
+packages/api/src/client
+packages/bsky/src/lexicon
+packages/pds/src/lexicon
+packages/ozone/src/lexicon

packages/api/jest.config.js

@@ -5,4 +5,5 @@ module.exports = {
   testTimeout: 60000,
   setupFiles: ['<rootDir>/../../jest.setup.ts'],
   setupFilesAfterEnv: ['<rootDir>/jest.setup.ts'],
+  moduleNameMapper: { '^(\\.\\.?\\/.+)\\.js$': ['$1.ts', '$1.js'] },
 }