Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expected behavior:
tlogwriter
driver now accepts awhen
argument, which can be eitheralways
orwhile_arm
.always
to match the same behavior from mavlink-router, which is only configurable via conf-file, as described here. For this reason, this patch introduces a major behavior change.path
is a folder that doesn't exist, it will try to create the entire path.while_arm
, it will start a new file every time the vehicle changes fromdisarmed
toarmed
, following the same file name format asmavlink-router
. On the other way around (when the vehicle changed fromdisarmed
toarmed
), it closes the file.while_arm
, the system_id and component_id from which it monitors the heartbeats can be configured from endpoint arguments, falling back to the same behavior as mavlink-router: it gets the system ID from the first heartbeat sent by an autopilot (component id 1).Closes #54.