Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve tlog writer: log when arm #118

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

joaoantoniocardoso
Copy link
Member

@joaoantoniocardoso joaoantoniocardoso commented Feb 21, 2025

Expected behavior:

  1. The tlogwriter driver now accepts a when argument, which can be either always or while_arm.
  2. The default value for this argument is always to match the same behavior from mavlink-router, which is only configurable via conf-file, as described here. For this reason, this patch introduces a major behavior change.
  3. If the passed path is a folder that doesn't exist, it will try to create the entire path.
  4. When operating as while_arm, it will start a new file every time the vehicle changes from disarmed to armed, following the same file name format as mavlink-router. On the other way around (when the vehicle changed from disarmed to armed), it closes the file.
  5. When operating as while_arm, the system_id and component_id from which it monitors the heartbeats can be configured from endpoint arguments, falling back to the same behavior as mavlink-router: it gets the system ID from the first heartbeat sent by an autopilot (component id 1).
  • Tested locally
  • Tested on the vehicle w/ Navigator

Closes #54.

@joaoantoniocardoso joaoantoniocardoso force-pushed the tlog_writer branch 3 times, most recently from a54ca13 to 78a385e Compare February 21, 2025 23:08
@joaoantoniocardoso joaoantoniocardoso changed the title Tlog writer Improve tlog writer: log when arm Feb 21, 2025
@joaoantoniocardoso joaoantoniocardoso force-pushed the tlog_writer branch 3 times, most recently from 9f197af to 3a3d20d Compare February 24, 2025 19:55
@joaoantoniocardoso joaoantoniocardoso marked this pull request as ready for review February 24, 2025 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make tlogw better
1 participant