-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
src: components: edit-menu: improve widget reordering icons #680
Merged
rafaellehmkuhl
merged 1 commit into
bluerobotics:master
from
ES-Alexander:widget-drag-intuition
Jan 26, 2024
Merged
src: components: edit-menu: improve widget reordering icons #680
rafaellehmkuhl
merged 1 commit into
bluerobotics:master
from
ES-Alexander:widget-drag-intuition
Jan 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a99d888
to
f041918
Compare
I think I've fixed this, but haven't set up Cockpit building yet, so haven't actually checked. |
e4e4fa8
to
db11994
Compare
rafaellehmkuhl
requested changes
Jan 26, 2024
db11994
to
b0cf6be
Compare
rafaellehmkuhl
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Better match the suggestions in #448, by using the more commonly accepted dragging/reordering icon, and adding an up/down arrow to make it more obvious that reordering is possible.
Untested - spacing may need to be adjusted.