Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: components: edit-menu: improve widget reordering icons #680

Merged

Conversation

ES-Alexander
Copy link
Contributor

Better match the suggestions in #448, by using the more commonly accepted dragging/reordering icon, and adding an up/down arrow to make it more obvious that reordering is possible.

Untested - spacing may need to be adjusted.

Copy link
Member

@rafaellehmkuhl rafaellehmkuhl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the new drag icon.

About the arrow, could you try making it vertically aligned with the text and with a more pale color, so the text is in focus and the arrow is subtle?

image

@ES-Alexander ES-Alexander force-pushed the widget-drag-intuition branch from a99d888 to f041918 Compare January 23, 2024 04:48
@ES-Alexander
Copy link
Contributor Author

About the arrow, could you try making it vertically aligned with the text and with a more pale color, so the text is in focus and the arrow is subtle?

I think I've fixed this, but haven't set up Cockpit building yet, so haven't actually checked.

@rafaellehmkuhl
Copy link
Member

About the arrow, could you try making it vertically aligned with the text and with a more pale color, so the text is in focus and the arrow is subtle?

I think I've fixed this, but haven't set up Cockpit building yet, so haven't actually checked.

Just checked and it is the same way as before :(

image

@ES-Alexander ES-Alexander force-pushed the widget-drag-intuition branch 2 times, most recently from e4e4fa8 to db11994 Compare January 26, 2024 07:57
@ES-Alexander
Copy link
Contributor Author

Got building working so I could actually view stuff, and decided to choose a different arrow that's more intuitive:
Screenshot 2024-01-26 at 6 57 05 pm

@ES-Alexander ES-Alexander added the docs-needed Change needs to be documented label Jan 26, 2024
@rafaellehmkuhl
Copy link
Member

Got building working so I could actually view stuff, and decided to choose a different arrow that's more intuitive: Screenshot 2024-01-26 at 6 57 05 pm

Thats's waaaaay better!! Loved it.

@rafaellehmkuhl rafaellehmkuhl merged commit 60c0536 into bluerobotics:master Jan 26, 2024
7 checks passed
@ES-Alexander ES-Alexander deleted the widget-drag-intuition branch September 16, 2024 18:59
@ES-Alexander ES-Alexander added the docs-in-progress Included in an open docs PR label Jan 2, 2025
@ES-Alexander ES-Alexander added docs-complete Change documentation has been completed and removed docs-needed Change needs to be documented docs-in-progress Included in an open docs PR labels Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-complete Change documentation has been completed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants