Merge configuration tables for custom actions into one #1674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit merges the configuration menus for all custom actions into a single table, common to all action types. This ensures that the configuration for each action type is consistent and easy to manage, as well as reducing the amount of code in each action configuration component.
rafaellehmkuhl
force-pushed
the
merge-menu-custom-actions
branch
from
dd026a3 to
da4d7c4
Compare
rafaellehmkuhl
changed the title
ES-Alexander
approved these changes
Feb 6, 2025
There was a problem hiding this comment.
Nice!
A couple of caveats, that might be worth changing/fixing here/soon:
- There's only one section now, so it's weird that it's collapsible
- Custom Actions can be replaced without warning #1673 is now more confusing, because some name conflicts in the table are ok, but not ones with the same type
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kapture.2025-02-06.at.14.16.40.mp4
Before and after:
Contributes to #1573.