Changes for running plugin in Mura 6.2 #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I see that you have fixed several of the things that I ran into here; using fileWrite(), getting the value of "notifyemail" instead of "email". The only other thing I would suggest is not dumping and aborting. The catch already has some error handling to write the output file. Unless you found some other issue there. Probably same for if the email fails.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I see that you have fixed several of the things that I ran into here; using fileWrite(), getting the value of "notifyemail" instead of "email". The only other thing I would suggest is not dumping and aborting. The catch already has some error handling to write the output file. Unless you found some other issue there. Probably same for if the email fails.