Fix build with setuptools-scm >= 8 #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This moves the build from using the deprecated `setup_requires` declaration to specifying build dependencies as specified in PEP 517. This should fix the build issues that PR #210 has been running into.
Using setup.py to run tests is a mechanism that has already been deprecated for ages and nobody should rely on anyhow.
Having pytest configuration in setup.cfg if there is also a pyproject.toml could be suprising for some. Moving it to pyproject.toml allows us to completely remove the setup.cfg file, giving users one less place to look for it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the build from using the deprecated
setup_requiresdeclaration to specifying build dependencies as specified in PEP 517.This should fix the build issues that PR #210 has been running into.