Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stats: show current calculated day as dotted point #826

Closed
sevenzing opened this issue Apr 8, 2024 · 2 comments
Closed

stats: show current calculated day as dotted point #826

sevenzing opened this issue Apr 8, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@sevenzing
Copy link
Contributor

For now, the stats API removes the last point from the response if the value was calculated today::
https://github.com/blockscout/blockscout-rs/blob/main/stats/stats-server/src/read_service.rs#L98

We actually want to display this point, but add a note to inform the user that this value is partially calculated. For example, from Mixpanel::

Image

This feature requires API changes, so one should discuss with the frontend team the best way to implement it

@sevenzing sevenzing added this to the stats milestone Apr 8, 2024
@sevenzing sevenzing added the enhancement New feature or request label Apr 8, 2024
@bragov4ik bragov4ik self-assigned this Apr 8, 2024
@sevenzing sevenzing mentioned this issue Apr 26, 2024
9 tasks
@bragov4ik
Copy link
Contributor

i think it makes sense to link pr #836
👀

@bragov4ik
Copy link
Contributor

This feature is deployed in backend. There are some issues (probably with update logic) that result in too inaccurate approximate points, but this should not be a problem in v2 due to large refactor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants