Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make staging the default branch #6

Closed
4 of 6 tasks
tweakch opened this issue Aug 10, 2021 · 1 comment
Closed
4 of 6 tasks

Make staging the default branch #6

tweakch opened this issue Aug 10, 2021 · 1 comment
Assignees

Comments

@tweakch
Copy link
Collaborator

tweakch commented Aug 10, 2021

Description

As expected, secrets are not passed to the runner when the PR is coming from a fork.

The difference can be seen here:

So we can only run the CI build when merging from local branches.

I am not a devops expert, but here are my suggestions on how to setup branches to streamline pull requests.

We could

  • rename master to staging (keep as default)
  • add a new branch main (not default)
  • run the CI builds only on main
  • tag releases on main #11

We must

This would make it possible to setup different workflows for PRs and release / integration tests

@mmahut
Copy link
Member

mmahut commented Aug 10, 2021

The branches are renamed and protected.

@tweakch tweakch closed this as completed Aug 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants