Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(addresses): payment_cred stake_address: null #187

Merged
merged 2 commits into from
Jul 30, 2024

Conversation

1000101
Copy link
Contributor

@1000101 1000101 commented Jul 30, 2024

Previously, first queried stake address was displayed. But since tthere can be multiple stake addresses for a given payment_cred, this information was not correct. The fix is to always display null instead of a random stake_address.

Testing vector:
http://localhost:3000/addresses/addr_vkh1vt2ntv45rx6e7rfk2qfw2434kdnl0k8fl4h3h6p55d2j6k6czz3

Current state:

{
  "address": "addr_vkh1vt2ntv45rx6e7rfk2qfw2434kdnl0k8fl4h3h6p55d2j6k6czz3",
  "amount": [
    {
      "unit": "lovelace",
      "quantity": "20000000"
    }
  ],
  "stake_address": "stake_test1upnhn29zpdwaje5myechf05094s4crp04vnzusqlwg59f4qjx6t73",
  "type": "shelley",
  "script": false
}

This PR:

{
  "address": "addr_vkh1vt2ntv45rx6e7rfk2qfw2434kdnl0k8fl4h3h6p55d2j6k6czz3",
  "amount": [
    {
      "unit": "lovelace",
      "quantity": "20000000"
    }
  ],
  "stake_address": null,
  "type": "shelley",
  "script": false
}

@vladimirvolek vladimirvolek merged commit 236eda5 into master Jul 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants