feat(desktop-ui): Command/ctrl + comma goes to Settings view #1439
+23
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewdiamant
force-pushed
the
mdiamant/command-comma-settings
branch
from
6ee3eb5 to
42fa72d
Compare
baxen
approved these changes
Feb 28, 2025
| @@ -228,7 +228,7 @@ export default function MoreMenu({ setView }: { setView: (view: View) => void }) | |||
| }} | |||
| className="w-full text-left p-2 text-sm hover:bg-bgSubtle transition-colors" | |||
| > | |||
| Settings | |||
| Settings (cmd+,) | |||
There was a problem hiding this comment.
tiny nit: would show this as ⌘,
(or i think electron has a helper to do ⌘/^ depending if on windows? but i can't seem to find it and this is something we can review later when we have more official windows support)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A very standard shortcut is Command + comma (or Ctrl + comma) to go to an App's settings or preferences (try it out on Slack, Notion, Discord, or your favorite app).
Also adding Settings to the app menu, after the About item, which is also where Chrome/Notion/Slack has it.
Also, adding the general ability to change views with the
'set-view'message.