Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: check file type with validation #1405

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nahiyankhan
Copy link
Collaborator

This feature adds a check to make sure the selected file is of type text and not binary. If the user selects a filetype thats not allowed, a system modal shows an error.

Screenshot 2025-02-26 at 8 53 20 PM

@nahiyankhan
Copy link
Collaborator Author

@alexhancock @lily-de - I wonder if this is restrictive in the sense that the wrong file sent to goose does give back some feedback on why it might not work. I noticed that for .docx or so - it suggests using a text extractor. Thoughts on whether goose should make a reasonable attempt or it's up to the user?

@lily-de
Copy link
Collaborator

lily-de commented Feb 27, 2025

@nahiyankhan i think if goose can reliably do it for docx it can try! sounds cool. does it start like programming something lol? i think that will freak non-devs out a bit 👻

@nahiyankhan
Copy link
Collaborator Author

@nahiyankhan i think if goose can reliably do it for docx it can try! sounds cool. does it start like programming something lol? i think that will freak non-devs out a bit 👻

It doesn't attempt by default - but does suggest options and whether I want to try them! I'll file it under future consideration for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants