Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update approve prompt #1383

Merged
merged 1 commit into from
Feb 26, 2025
Merged

fix: update approve prompt #1383

merged 1 commit into from
Feb 26, 2025

Conversation

yingjiehe-xyz
Copy link
Collaborator

@yingjiehe-xyz yingjiehe-xyz commented Feb 25, 2025

Right now, we have two Goose would like to call the above tool. Allow? (y/n): in the terminal screen.

Before:

( O)> write a test.txt to my dir
I'll help you write a test.txt file to the current directory. I'll use the text editor tool to create this file.

─── text_editor | developer ──────────────────────────
path: ~/Documents/block/goose/test.txt
command: write
file_text: This is a test file.


Goose would like to call the above tool. Allow? (y/n):

( O)> y
Goose would like to call the above tool. Allow? (y/n):

### /Users/yingjiehe/Documents/block/goose/test.txt

After

( O)> write a test.txt to my dir
I'll help you write a test.txt file in the current directory. I'll use the text editor tool to create this file.

─── text_editor | developer ──────────────────────────
path: ~/Documents/block/goose/test.txt
command: write
file_text: This is a test file.


Goose would like to call the above tool. Allow? (y/n):

( O)> y
### /Users/yingjiehe/Documents/block/goose/test.txt

Copy link
Collaborator

@wendytang wendytang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

may have to merge with #1377

@yingjiehe-xyz yingjiehe-xyz changed the title fix: avoid duplicate confirmation message rendered fix: update approve prompt Feb 26, 2025
@yingjiehe-xyz yingjiehe-xyz merged commit fd3ebee into main Feb 26, 2025
6 checks passed
@yingjiehe-xyz yingjiehe-xyz deleted the yingjiehe/approve branch February 26, 2025 16:54
salman1993 added a commit that referenced this pull request Feb 27, 2025
* origin/main: (26 commits)
  feat: Read .gooseignore to Restrict access to files or Directories (#1199)
  docs: adding update command to cli command guide (#1411)
  docs: Adding YT short for Computer Controller Tutorial (#1420)
  feat(cli): support arbitrary path for sessions (#1414)
  feat: remove the disable state from chat input box (#1341)
  feat: Add extra details to prompt for gui (#1387)
  style: added launch text and styling (#1406)
  fix(docs): update default session location (#1412)
  feat: moved extension add button and updated label (#1408)
  draft: use rust messages in typescript (#1393)
  fix: detect read only tool when only mode is approve (#1398)
  docs: Add Puppeteer Extension Tutorial (#1396)
  chore(release): release version v1.0.10 (#1404)
  chore(release): release 1.10.0  (#1385)
  feat: wip on ConfigProvider and integration in settings_v2 (#1395)
  feat: Add command `goose update` to update goose CLI version (#1308)
  fix: update approve prompt (#1383)
  feat: interactive after run (#1377)
  docs: Tutorial extension (#1379)
  feat: allow setting openai base path (#1369)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants