feat: allow setting openai base path #1369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angiejones
reviewed
Feb 24, 2025
| @@ -3,7 +3,7 @@ | |||
| "name": "OpenAI", | |||
| "description": "Use GPT-4 and other OpenAI models", | |||
| "models": ["gpt-4o", "gpt-4-turbo","o1"], | |||
| "required_keys": ["OPENAI_API_KEY", "OPENAI_HOST"] | |||
| "required_keys": ["OPENAI_API_KEY", "OPENAI_HOST", "OPENAI_BASE_PATH"] | |||
There was a problem hiding this comment.
any way to make this optional with its current default value?
There was a problem hiding this comment.
yes, it is the default value right now: https://github.com/block/goose/pull/1369/files#diff-927fbda385d9381b208dba5eac1e2ad594c65872e466f8f5cecb9472271d7ae3R80
There was a problem hiding this comment.
but i still need to enter it, right?
There was a problem hiding this comment.
no, it will have the default value in the input field
angiejones
approved these changes
Feb 25, 2025
salman1993
added a commit
that referenced
this pull request
Feb 27, 2025
* origin/main: (26 commits) feat: Read .gooseignore to Restrict access to files or Directories (#1199) docs: adding update command to cli command guide (#1411) docs: Adding YT short for Computer Controller Tutorial (#1420) feat(cli): support arbitrary path for sessions (#1414) feat: remove the disable state from chat input box (#1341) feat: Add extra details to prompt for gui (#1387) style: added launch text and styling (#1406) fix(docs): update default session location (#1412) feat: moved extension add button and updated label (#1408) draft: use rust messages in typescript (#1393) fix: detect read only tool when only mode is approve (#1398) docs: Add Puppeteer Extension Tutorial (#1396) chore(release): release version v1.0.10 (#1404) chore(release): release 1.10.0 (#1385) feat: wip on ConfigProvider and integration in settings_v2 (#1395) feat: Add command `goose update` to update goose CLI version (#1308) fix: update approve prompt (#1383) feat: interactive after run (#1377) docs: Tutorial extension (#1379) feat: allow setting openai base path (#1369) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test:
