-
Notifications
You must be signed in to change notification settings - Fork 622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cli): add mcp prompt support via slash commands #1323
Merged
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
34a4bac
feat: add prompts support to mcp-client, ahere to MCP spec for prompts
kalvinnchau 5c4258b
feat: handle JsonRpcMessage::Error messages to propagate to the user
kalvinnchau 2523e61
test: update MockClient in test with list_prompts and get_prompt
kalvinnchau 529b7fd
feat: remove concrete impl of get_prompt and list_prompts, and requir…
kalvinnchau a0110ac
test: add impl of list/get prompt to main.rs and stdio_integration to…
kalvinnchau 0f776c0
refactor: implement list_prompts and get_prompts for mcp servers
kalvinnchau 7d0cb11
feat: add list prompts command
kalvinnchau ead9c1d
feat: add /prompt $NAME --info and placeholder for exeuction
kalvinnchau 8025a93
refactor: revert handle_slash_command, match existing patterns
kalvinnchau 2407051
feat: first pass at enabling /prompt support, just rendering the output
kalvinnchau dd4cddb
feat: convert prompt messages to agent messages, and handle prompt in
kalvinnchau 5e5d7e9
Merge branch 'main' into kalvin/mcp-prompt
kalvinnchau a1ef0b9
style: cargo fmt after merge
kalvinnchau e86c75d
Merge branch 'main' into kalvin/mcp-prompt
kalvinnchau e2ef3d1
refactor: cleanup PromptMessage to Message using impl From
kalvinnchau 1c2a15a
feat: enforce PromptMessages that we start with User messages
kalvinnchau File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if we invoked a PromptMessage that starts with assistant role - i think that would error because the CLI assumes its user msg and we also need to alternate between user & assistant. can you check this? if so, we might wanna enforce some checks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added enforcement for user first, and that the messages alternate user & assistant