Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add command goose update to update goose CLI version #1308

Merged
merged 5 commits into from
Feb 26, 2025
Merged

feat: Add command goose update to update goose CLI version #1308

merged 5 commits into from
Feb 26, 2025

Conversation

inmzhang
Copy link
Contributor

No description provided.

@cloudripper
Copy link

cloudripper commented Feb 20, 2025 •
edited
Loading

This is a valuable addition. To enhance build configurations for immutable systems, perhaps we could introduce an environment variable (e.g., DISABLE_CLI_UPDATES) that allows users to opt out of and disable CLI-based updates.

@inmzhang
Copy link
Contributor Author

This is a valuable addition. To enhance build configurations for immutable systems, perhaps we could introduce an environment variable (e.g., DISABLE_CLI_UPDATES) that allows users to opt out of and disable CLI-based updates.

Thanks for the suggestion. I'm not familiar with immutable systems, so not sure it's better to skip the update silently or raise an error when DISABLE_CLI_UPDATES is set. Currently, the latter is implemented.

@cliffhall
Copy link

I just want to duck my head in here and vote for this one. I have a ./update_goose.sh that I run all the time, but yes, this really seems like the right way for updates to happen.

@inmzhang inmzhang changed the title Add command goose update to update goose CLI version feat: Add command goose update to update goose CLI version Feb 21, 2025
alexhancock
alexhancock approved these changes Feb 26, 2025
View reviewed changes
Copy link
Collaborator

@alexhancock alexhancock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would remove the check for DISABLE_CLI_UPDATES as I think it makes sense not to need to check if the user is running an explicit goose update command.

Then good to merge. Thanks for the contribution!

@inmzhang
Copy link
Contributor Author

Hi Alex, thanks for the review. The change is applied, waiting for approval of CI checks...

@salman1993
Copy link
Collaborator

salman1993 commented Feb 26, 2025 •
edited
Loading

thanks for contributing! the formatting check is failing - cargo fmt should fix it

@alexhancock alexhancock merged commit 26348a6 into block:main Feb 26, 2025
8 checks passed
salman1993 added a commit that referenced this pull request Feb 27, 2025
@salman1993
Merge remote-tracking branch 'origin/main' into sm/plan-slash-command
a84fffd 
* origin/main: (26 commits)
  feat: Read .gooseignore to Restrict access to files or Directories (#1199)
  docs: adding update command to cli command guide (#1411)
  docs: Adding YT short for Computer Controller Tutorial (#1420)
  feat(cli): support arbitrary path for sessions (#1414)
  feat: remove the disable state from chat input box (#1341)
  feat: Add extra details to prompt for gui (#1387)
  style: added launch text and styling (#1406)
  fix(docs): update default session location (#1412)
  feat: moved extension add button and updated label (#1408)
  draft: use rust messages in typescript (#1393)
  fix: detect read only tool when only mode is approve (#1398)
  docs: Add Puppeteer Extension Tutorial (#1396)
  chore(release): release version v1.0.10 (#1404)
  chore(release): release 1.10.0  (#1385)
  feat: wip on ConfigProvider and integration in settings_v2 (#1395)
  feat: Add command `goose update` to update goose CLI version (#1308)
  fix: update approve prompt (#1383)
  feat: interactive after run (#1377)
  docs: Tutorial extension (#1379)
  feat: allow setting openai base path (#1369)
  ...
kalvinnchau added a commit that referenced this pull request Feb 27, 2025
@kalvinnchau
Merge branch 'main' into kalvin/mcp-prompt
e86c75d 
* main:
  feat: allow user to turn off smart approve (#1407)
  feat: Read .gooseignore to Restrict access to files or Directories (#1199)
  docs: adding update command to cli command guide (#1411)
  docs: Adding YT short for Computer Controller Tutorial (#1420)
  feat(cli): support arbitrary path for sessions (#1414)
  feat: remove the disable state from chat input box (#1341)
  feat: Add extra details to prompt for gui (#1387)
  style: added launch text and styling (#1406)
  fix(docs): update default session location (#1412)
  feat: moved extension add button and updated label (#1408)
  draft: use rust messages in typescript (#1393)
  fix: detect read only tool when only mode is approve (#1398)
  docs: Add Puppeteer Extension Tutorial (#1396)
  chore(release): release version v1.0.10 (#1404)
  chore(release): release 1.10.0  (#1385)
  feat: wip on ConfigProvider and integration in settings_v2 (#1395)
  feat: Add command `goose update` to update goose CLI version (#1308)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexhancock alexhancock alexhancock approved these changes

@salman1993 salman1993 salman1993 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@inmzhang @cloudripper @cliffhall @salman1993 @alexhancock