Bugfixin #56
Merged
Bugfixin #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
April 26, 2017 20:12
prevent them from constantly updating their phone number each time they sign in by only rendering the phone form if it's a new user
kfoxb
requested changes
Apr 27, 2017
app/AllFriendsList.js
Outdated
| @@ -63,14 +63,20 @@ export default class AllFriendsList extends Component { | |||
|
|
|||
| renderContacts(friend) { | |||
| const { navigate } = this.props.navigation; | |||
| var privacy = friend.showSetting; | |||
| var label = friend.currentLabel; | |||
app/Home.js
Outdated
| @@ -46,13 +46,19 @@ export default class HomeScreen extends Component { | |||
|
|
|||
| renderMembers(memberData) { | |||
| const { navigate } = this.props.navigation; | |||
| var privacy = memberData.showSetting; | |||
There was a problem hiding this comment.
There was another var right below this one too :-)
app/SignUp.js
Outdated
| data: {phoneNumber: this.state.phoneNumber} | ||
| }) | ||
| .then(({data}) => { | ||
| console.log('updated user after google sign in save location: ', data); |
There was a problem hiding this comment.
Do we need this console.log in production?
app/SignUp.js
Outdated
| }) | ||
| .then(({data}) => { | ||
| console.log('updated user after google sign in save location: ', data); | ||
| this.setState({dbUser: data}, () => console.log('state after dbuser: ', this.state)); |
There was a problem hiding this comment.
Do we need this console.log in production?
kfoxb
approved these changes
Apr 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent constantly updating phone number, prevent taking an existing user through the sign up process, etc.