Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1291 notes logged in user opens notes #1293

Conversation

nickcastel50
Copy link
Contributor

Fix #1291

  • remove auth check useEffect in NotesNavBar.jsx

@nickcastel50 nickcastel50 added the enhancement New feature or request label Dec 10, 2024
@nickcastel50 nickcastel50 self-assigned this Dec 10, 2024
Copy link

netlify bot commented Dec 10, 2024

Deploy Preview for bldrs-share ready!

Name Link
🔨 Latest commit 555b763
🔍 Latest deploy log https://app.netlify.com/sites/bldrs-share/deploys/6758b8fb8c40d00008f1f8dc
😎 Deploy Preview https://deploy-preview-1293--bldrs-share.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 0 (no change from production)
Accessibility: 89 (no change from production)
Best Practices: 92 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 10, 2024

Deploy Preview for bldrs-share-prod ready!

Name Link
🔨 Latest commit 555b763
🔍 Latest deploy log https://app.netlify.com/sites/bldrs-share-prod/deploys/6758b8fb6cd37c000892c3fc
😎 Deploy Preview https://deploy-preview-1293--bldrs-share-prod.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@pablo-mayrgundter pablo-mayrgundter changed the title Fix #1291 1291 notes logged in user opens notes Dec 10, 2024
@nickcastel50 nickcastel50 merged commit a3a15b3 into main Dec 10, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Notes: Logged in user opens Notes, gets CommentCreate instead of Notes
2 participants