Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update base image #15103

Merged
merged 16 commits into from
Dec 18, 2024
Merged

Update base image #15103

merged 16 commits into from
Dec 18, 2024

Conversation

NickM-27
Copy link
Collaborator

Proposed change

Updates the base image to debian bullseye

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code
  • Documentation Update

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • The code has been formatted using Ruff (ruff format frigate)

@NickM-27 NickM-27 force-pushed the update-base-image branch 2 times, most recently from 3da3b6b to 44ee624 Compare November 20, 2024 20:36
@systemtester systemtester mentioned this pull request Nov 21, 2024
@NickM-27 NickM-27 force-pushed the 0.16 branch 3 times, most recently from 177d8b3 to 34f51bf Compare December 1, 2024 14:49
@NickM-27 NickM-27 force-pushed the 0.16 branch 5 times, most recently from 098699d to 6178209 Compare December 7, 2024 19:26
@NickM-27 NickM-27 force-pushed the 0.16 branch 3 times, most recently from 46c9fae to 5db16c3 Compare December 12, 2024 14:46
@NickM-27 NickM-27 force-pushed the update-base-image branch 5 times, most recently from ecf6433 to e4311a6 Compare December 16, 2024 13:42
@NickM-27
Copy link
Collaborator Author

NickM-27 commented Dec 17, 2024

CC @MarcA711

Looks like there shouldn't be any required changes on rockchip side but just wanted to make sure you are aware of this

@MarcA711
Copy link
Contributor

@NickM-27 I will test it ASAP. Perhaps over the weekend. Thank you for notifying me.

@NickM-27 NickM-27 linked an issue Dec 17, 2024 that may be closed by this pull request
@NickM-27 NickM-27 marked this pull request as ready for review December 18, 2024 16:24
@NickM-27 NickM-27 requested a review from hawkeye217 December 18, 2024 16:24
@NickM-27 NickM-27 merged commit c4af920 into 0.16 Dec 18, 2024
5 checks passed
@NickM-27 NickM-27 deleted the update-base-image branch December 18, 2024 16:46
NickM-27 added a commit that referenced this pull request Dec 19, 2024
* Change base image

* Update python

* Update coral library

* Fix source file

* Install correct apt packages

* Cleanup

* Fix installation of coral deps

* fix python installations

* Fix devcontainer build

* Get tensorrt build working

* Update other deps

* Filter out tflite log

* Get ROCm build working

* Get rockchip build working

* Get hailo build working

* Add note to comment
weitheng pushed a commit to weitheng/frigate that referenced this pull request Dec 21, 2024
weitheng pushed a commit to weitheng/frigate that referenced this pull request Dec 21, 2024
@MarcA711
Copy link
Contributor

Hey @NickM-27, I am currently looking into updating the rockchip image. I want to update the detection models. It seems yolonas from super-gradients was abandoned, at least the URLs for downloading yolonas are broken and there is no recent activity in the repo or support on issues. So this notebook from the frigate repo will also not works: https://github.com/blakeblackshear/frigate/blob/dev/notebooks/YOLO_NAS_Pretrained_Export.ipynb

What model should I use? Are ultralytics models still not useable due to the license issues? Or do newer models like yolo11 have another license?

Moreover, I saw that there are new AI features in the new frigate version. Is there a way to accelerate this on different hardware (similar to detectors)?

@NickM-27
Copy link
Collaborator Author

We can take another look and see if there is a way to get the YOLONAS notebook working.

What model should I use? Are ultralytics models still not useable due to the license issues? Or do newer models like yolo11 have another license?

I am not entirely sure what the current rockchip options are, nothing has changed regarding ultralytics models, I believe there are some re-implementations of some of the YOLO model architectures without the AGPL3 license.

Moreover, I saw that there are new AI features in the new frigate version. Is there a way to accelerate this on different hardware (similar to detectors)?

Many platforms are supported, all of this is done through ONNX runtime. It looks like Rockchip has an ONNX runtime execution provider that is currently in preview state https://onnxruntime.ai/docs/execution-providers/community-maintained/RKNPU-ExecutionProvider.html

@MarcA711
Copy link
Contributor

We can take another look and see if there is a way to get the YOLONAS notebook working.

Someone mentioned here that one can download the weights manually. I will try to do this.

I  am not entirely sure what the current rockchip options are, nothing has changed regarding ultralytics models, I believe there are some re-implementations of some of the YOLO model architectures without the AGPL3 license.

The ones that are supported best and are optimized for Rockchip are listed here. However, almost every object detection model should work.

Many platforms are supported, all of this is done through ONNX runtime. It looks like Rockchip has an ONNX runtime execution provider that is currently in preview state https://onnxruntime.ai/docs/execution-providers/community-maintained/RKNPU-ExecutionProvider.html

Unfortunately this is for the old generation of socs (not supported by Frigate and used by fewer people). Moreover, this has been in Preview state with no progress for years. I doubt that this will ever be finished.
Maybe I will find another way to implement this. I will have a look.

@NickM-27
Copy link
Collaborator Author

I imagine mobilenetv2 would be good to support at a minimum for a built in model and parity with other detectors.

Unfortunately this is for the old generation of socs (not supported by Frigate and used by fewer people). Moreover, this has been in Preview state with no progress for years.

Dang that's unfortunate

NickM-27 added a commit that referenced this pull request Dec 22, 2024
* Change base image

* Update python

* Update coral library

* Fix source file

* Install correct apt packages

* Cleanup

* Fix installation of coral deps

* fix python installations

* Fix devcontainer build

* Get tensorrt build working

* Update other deps

* Filter out tflite log

* Get ROCm build working

* Get rockchip build working

* Get hailo build working

* Add note to comment
NickM-27 added a commit that referenced this pull request Dec 22, 2024
* Change base image

* Update python

* Update coral library

* Fix source file

* Install correct apt packages

* Cleanup

* Fix installation of coral deps

* fix python installations

* Fix devcontainer build

* Get tensorrt build working

* Update other deps

* Filter out tflite log

* Get ROCm build working

* Get rockchip build working

* Get hailo build working

* Add note to comment
NickM-27 added a commit that referenced this pull request Dec 23, 2024
* Change base image

* Update python

* Update coral library

* Fix source file

* Install correct apt packages

* Cleanup

* Fix installation of coral deps

* fix python installations

* Fix devcontainer build

* Get tensorrt build working

* Update other deps

* Filter out tflite log

* Get ROCm build working

* Get rockchip build working

* Get hailo build working

* Add note to comment
weitheng pushed a commit to weitheng/frigate that referenced this pull request Dec 23, 2024
weitheng pushed a commit to weitheng/frigate that referenced this pull request Dec 23, 2024
NickM-27 added a commit that referenced this pull request Dec 26, 2024
* Change base image

* Update python

* Update coral library

* Fix source file

* Install correct apt packages

* Cleanup

* Fix installation of coral deps

* fix python installations

* Fix devcontainer build

* Get tensorrt build working

* Update other deps

* Filter out tflite log

* Get ROCm build working

* Get rockchip build working

* Get hailo build working

* Add note to comment
weitheng pushed a commit to weitheng/frigate that referenced this pull request Jan 3, 2025
NickM-27 added a commit that referenced this pull request Jan 8, 2025
* Change base image

* Update python

* Update coral library

* Fix source file

* Install correct apt packages

* Cleanup

* Fix installation of coral deps

* fix python installations

* Fix devcontainer build

* Get tensorrt build working

* Update other deps

* Filter out tflite log

* Get ROCm build working

* Get rockchip build working

* Get hailo build working

* Add note to comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade Python
3 participants