Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support desktop touchscreens for timelines #11241

Merged
merged 3 commits into from
May 5, 2024
Merged

Conversation

hawkeye217
Copy link
Collaborator

@hawkeye217 hawkeye217 commented May 4, 2024

  • Desktop touchscreens can fire a TouchEvent, so remove the isMobile check for dragging timeline handlebars
  • Remove placeholder select dropdown in General settings
  • Set max height on Settings cameras dropdown

Copy link

netlify bot commented May 4, 2024

Deploy Preview for frigate-docs canceled.

Name Link
🔨 Latest commit 42fe6f4
🔍 Latest deploy log https://app.netlify.com/sites/frigate-docs/deploys/6636be5379400d000803df48

@NickM-27 NickM-27 merged commit ca8ef70 into dev May 5, 2024
13 checks passed
@NickM-27 NickM-27 deleted the desktop-touchscreens branch May 5, 2024 03:00
@deviant77
Copy link
Contributor

This broke scrubbing through history for me in Firefox 125 on Linux, and gives the following errors in the developer console:

Uncaught ReferenceError: TouchEvent is not defined
    Q http://frigate:80/assets/SummaryTimeline-DWF-gQBS.js:1
    D http://frigate:80/assets/SummaryTimeline-DWF-gQBS.js:1
    yI http://frigate:80/assets/index-DU3HC9W5.js:38
    bI http://frigate:80/assets/index-DU3HC9W5.js:38
    _I http://frigate:80/assets/index-DU3HC9W5.js:38
    N4 http://frigate:80/assets/index-DU3HC9W5.js:38
    AE http://frigate:80/assets/index-DU3HC9W5.js:38
    vg http://frigate:80/assets/index-DU3HC9W5.js:38
    X2 http://frigate:80/assets/index-DU3HC9W5.js:41
    Q3 http://frigate:80/assets/index-DU3HC9W5.js:38
    vg http://frigate:80/assets/index-DU3HC9W5.js:38
    C2 http://frigate:80/assets/index-DU3HC9W5.js:38
    DI http://frigate:80/assets/index-DU3HC9W5.js:38
    NE http://frigate:80/assets/index-DU3HC9W5.js:38
    mg http://frigate:80/assets/index-DU3HC9W5.js:38
    Zu http://frigate:80/assets/index-DU3HC9W5.js:38
    Zu http://frigate:80/assets/index-DU3HC9W5.js:38
    createRoot http://frigate:80/assets/index-DU3HC9W5.js:41
    <anonymous> http://frigate:80/assets/index-DU3HC9W5.js:206
SummaryTimeline-DWF-gQBS.js:1:8208

Going back to ad87f57 fixed it.

@hawkeye217 hawkeye217 mentioned this pull request May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants