[stats] Fix tooltip showing as undefined for first tick #11150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for frigate-docs canceled.
|
xconverge
changed the title
hawkeye217
reviewed
Apr 29, 2024
|
this doesn't work on mobile, the first item is clipped which is why it returns when val == 1. I think we should adjust the logic to keep the val == 1 but only apply it to mobileOnly
|
|
@NickM-27 I removed the offsetX, even with removing the first tick, the X axis labels werent lining up correctly with the data being shown, even in your screenshot (if you use the tooltip to hover) This looks good to me now for both desktop and mobile 
|
NickM-27
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjust the offset logic to match the (already working) camera stats and fixes the first tooltip showing with a title of "undefined" instead of the time