Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stats] Add units to y axis labels #11149

Closed
wants to merge 2 commits into from

Conversation

xconverge
Copy link
Contributor

@xconverge xconverge commented Apr 29, 2024

No description provided.

Copy link

netlify bot commented Apr 29, 2024

Deploy Preview for frigate-docs canceled.

Name Link
🔨 Latest commit 74ca3f7
🔍 Latest deploy log https://app.netlify.com/sites/frigate-docs/deploys/662f2283f9ff7e0008dd19a6

@xconverge
Copy link
Contributor Author

xconverge commented Apr 29, 2024

This totally doesn't work, sorry, I need to write a different formatter for stepSize or something, will update it quickly

Just reverted the not working part and will come up with a different solution in a different/separate PR

@xconverge xconverge changed the title [stats] Add label to y axis and adjust step size if percentage [stats] Add label to y axis Apr 29, 2024
@xconverge xconverge changed the title [stats] Add label to y axis [stats] Add units to y axis labels Apr 29, 2024
@NickM-27
Copy link
Collaborator

Personally I think it looks cleaner without units, and the units show in the top so they are known. Maybe other maintainers will have a different opinion

Also on the % part we don't want the scale to always be 0-100 because then you lose the graph entirely when the % is low

@xconverge
Copy link
Contributor Author

Just to add some context of what I am seeing on my system and why I think it could use a tweak, what does yours look like?

image

For me this is mostly just a "pretty graphs" screen that doesnt really tell me much, but I dont need to make tweaks to cater specifically to my weird/low resources used system

The other fixes were more important for my system, so I will play with it more once I have those deployed and give it a few days to settle in

@NickM-27
Copy link
Collaborator

Seems fine to me, I'm not sure why the unit itself would make that much of a difference

Screenshot_20240428_231609_Chrome Beta.jpg

@xconverge
Copy link
Contributor Author

👍

@xconverge xconverge closed this Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants