Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Python #4394

Closed
felipecrs opened this issue Nov 14, 2022 · 14 comments · Fixed by #15103
Closed

Upgrade Python #4394

felipecrs opened this issue Nov 14, 2022 · 14 comments · Fixed by #15103
Labels
enhancement New feature or request pinned

Comments

@felipecrs
Copy link
Contributor

Python 3.10 and 3.11 have brought several performance improvements. I wonder if we can't benefit of them by upgrading Python (we are using Python 3.9).

@felipecrs felipecrs added the enhancement New feature or request label Nov 14, 2022
@NickM-27
Copy link
Collaborator

A number of dependencies for frigate don't support > 3.9, for example: google-coral/pycoral#58

@felipecrs
Copy link
Contributor Author

Thanks for the heads up.

@NickM-27 NickM-27 changed the title Upgrade Python to 3.11 Upgrade Python Nov 14, 2022
@Daniel-dev22
Copy link
Contributor

Python 3.10 support for tflite has recently been merged.

tensorflow/tensorflow#59423

@witold-gren
Copy link

@witold-gren
Copy link

Good discussion about pycoral and update this library to version 3.10 or higher
google-coral/pycoral#85

@systemtester
Copy link

Base image updates appear to resolve this (when complete). #15103

@levski
Copy link

levski commented Nov 22, 2024

am new to linux and am figuring out frigate with a tpu. this compatibility got me stumped.

The following packages have unmet dependencies:
python3-pycoral : Depends: python3-tflite-runtime (= 2.5.0.post1) but it is not going to be installed
Depends: python3 (< 3.10) but 3.11.2-1+b1 is to be installed
E: Unable to correct problems, you have held broken packages.

how'd y'all get around it?

@hawkeye217
Copy link
Collaborator

You should follow the Getting Started guide to install Frigate. You don't need to install those drivers directly.

https://docs.frigate.video/guides/getting_started

Additionally, if you continue to have issues, you should open a support discussion rather than commenting on old feature request threads.

@levski
Copy link

levski commented Nov 22, 2024

You should follow the Getting Started guide to install Frigate. You don't need to install those drivers directly.

https://docs.frigate.video/guides/getting_started

Additionally, if you continue to have issues, you should open a support discussion rather than commenting on old feature request threads.

yeah, after some more googling found a post that said so.
oh, didn't notice it was opened back in 2022.
all i saw what that there was a couple of recent post, figured it was still something people talked about.

@NickM-27 NickM-27 linked a pull request Dec 17, 2024 that will close this issue
10 tasks
@felipecrs
Copy link
Contributor Author

felipecrs commented Dec 18, 2024

Too bad #15103 is still Python 3.11. Maybe it would be worth switching the base image something like python:3.13-bullseye.

@NickM-27
Copy link
Collaborator

I don't think so, that will cause a lot more problems as many of our deps would have to be further updated and would be a massive amount of effort, I don't think being on the latest will help us, and this is already a major improvement being on 3.11

@felipecrs
Copy link
Contributor Author

Got it.

But Python 3.12 and then Python 3.13 brought significant overall performance improvement.

I'll see if I can do anything.

@NickM-27
Copy link
Collaborator

I'd highly suggest creating a discussion before putting too much time into it, I already looked in to various python versions and there will be a lot more work & various problems to solve regarding the different hardware platforms if we move forward to a newer version. IMO we don't want to have too many moving parts for 0.16 and this is already a big step forward.

@felipecrs
Copy link
Contributor Author

Alright, understood. Great to see Python 3.11 arriving!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request pinned
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants