-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Adding a missing data type for Time #267
Conversation
There is a bug here, though. It looks like the encoding is not working correctly: the tests pass but
UPDATE: fixed |
9062969
to
fa5d9e0
Compare
fa5d9e0
to
3136827
Compare
3136827
to
608e360
Compare
There is an issue with $ cat ./test.yaml
foo: aaa
bar: bbb
since: 2024-12-02T00:00:00Z
until: 2024-12-08T23:59:59Z
$ cat ./test.fabric
document "test" {
data yaml "test" {
path = "./test.yaml"
}
}
$ fabric data document.test.data.yaml.test
2024-12-20 11:44:39 WRN This is a dev version of the software! command=data version=0.4.2-dev+dirty.rev.bb58d06ad2950c5caab0a51cc085e34e3f56515b
2024-12-20 11:44:39 INF Parsing fabric files command=data directory=.
2024-12-20 11:44:39 INF Fetching data command=data target=document.test.data.yaml.test
2024-12-20 11:44:39 INF Loading document data command=data document=test datasource=yaml name=test
{
"bar": "bbb",
"foo": "aaa",
"since": ,
"until":
}
$ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. As for data cli command issue, it seems like there is a problem with library that is used to print this value:
github.com/TylerBrock/colorjson
Line 56 in 0dfddd6
fmt := colorjson.NewFormatter() |
If you disable color while running data command it prints correctly:
fabric data document.test.data.yaml.test --color=false
BTW, I think maybe we should also rename flag to --no-color
and flip value. Having bool default flags makes it requiring to pair them with =false
.
thanks for investigating the issue here, @dobarx! |
No description provided.