-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dynamic blocks and meta tags filtering #251
Conversation
@Andrew-Morozko awesome work here, and that's a great unit-test coverage, thank you! All of the behaviours there make sense to me. One question I had -- what is the order of evaluation when both |
In spec, condition determines whether or not dynamic item is shown at all, so it is always evaluated first. On the second thought, if it would be evaluated per dynamic item it would be a bit more more powerful, allowing to selectively hide only some dynamic items. Currently this could be done with by filtering within Although if it evaluated after items, it would loose access to parent's |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thank you @Andrew-Morozko
ad0f6dc
to
7d2dc05
Compare
Switch to proper parsing of synthetically generated title block, instead of generating a parsed struct
7d2dc05
to
47d9419
Compare
Resolves #142
Deviations from the spec:
dynamic
is not an attribute on a block, but a container block:dynamic_condition
is dropped, content blocks and sections can be conditionally included by usingis_included
attribute.There were a lot of corner cases in implementing this, @traut please check out the tests file and make sure that this is expected behaviour.
Dynamic blocks can contain multiple
section
andcontent
blocks and can be contained bydocument
andsection
blocks. They are transparently replaced by the children they're instantiating.Resolves #99
Deviations from the spec:
I named CLI argument in plural (
--with-meta-tags
)