Skip to content

Commit

Permalink
Remove TODO comments
Browse files Browse the repository at this point in the history
  • Loading branch information
maxwellmattryan committed Oct 31, 2024
1 parent 70735b2 commit 75080f4
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 2 deletions.
1 change: 0 additions & 1 deletion src/commands/freq.rs
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@ pub(crate) fn frequency_to_midi_note(frequency: f32) -> Option<u8> {
}
}

// TODO: Would be create to support inputs with the unit appended e.g. 440Hz or 440 Hz
fn try_frequency_from_str(arg: &str) -> FNoteResult<f32> {
let regex = Regex::new(r"^\d+(\.\d+)?$").unwrap();
if regex.is_match(arg) {
Expand Down
1 change: 0 additions & 1 deletion src/commands/note.rs
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ impl Command for NoteCommand {
}
}

// TODO: Better UX for valid music notes outside of MIDI value range.
/// Converts a music note to a MIDI note number.
fn music_note_to_midi_note_number(music_note: &str) -> FNoteResult<u8> {
let note_to_semitone = [
Expand Down

0 comments on commit 75080f4

Please sign in to comment.