Feat: biyooon, adding using zenohex #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s-hosoai
reviewed
Dec 19, 2024
s-hosoai
reviewed
Dec 24, 2024
lib/giocci_relay_zenoh.ex
Outdated
| end | ||
|
|
||
| def handle_info(:loop_engine2relay, state) do | ||
| # subをループするhandle info |
There was a problem hiding this comment.
関数ドキュメントとする場合は、関数の上で定義してください。
https://elixirschool.com/ja/lessons/basics/documentation#%E9%96%A2%E6%95%B0%E3%81%AE%E3%83%89%E3%82%AD%E3%83%A5%E3%83%A1%E3%83%B3%E3%83%88%E5%8C%96-3
関数ドキュメントなのか、関数内のコメントなのか判別がつきにくい箇所が多いので、見直しをお願いします。本来は全部ドキュメントが付くのが望ましいですが、今回は一旦あるものだけでおｋです。
There was a problem hiding this comment.
callbackな関数（handle_info, handle_call, handle_castなど）は関数ごとに@docおけなかったんじゃなかったかなぁと
おまいう案件ではあるかと
added 2 commits
December 25, 2024 21:14
added 2 commits
December 26, 2024 18:01
lib/giocci_relay_zenoh.ex
Outdated
Comment on lines
21
to
32
| @spec start_link(binary()) :: | ||
| {:ok, | ||
| %{ | ||
| callback_client2relay: (any(), map() -> :ok | {any(), any()}), | ||
| callback_engine2relay: (any(), map() -> :ok | {any(), any()}), | ||
| id: atom(), | ||
| publisher_relay2client: reference(), | ||
| publisher_relay2engine: reference(), | ||
| session: reference(), | ||
| subscriber_client2relay: Zenohex.Subscriber.t(), | ||
| subscriber_engine2relay: Zenohex.Subscriber.t() | ||
| }} |
There was a problem hiding this comment.
@fomfom あえて記載してる（残してる）って理解でOKですか？
lib/giocci_relay_zenoh.ex
Outdated
| {:ok, state} | ||
| end | ||
|
|
||
| ## Clientから送られたデータを解析して、やりたい動作ごとに割り振る予定 |
There was a problem hiding this comment.
@fomfom 実装が完了してたらコメントとっちゃいましょう
| end | ||
| end | ||
|
|
||
| ## Engineから送られたメッセージを抽出し、Clientに返送 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
一部の従来の機能に通信部分をZenohでおきかえたverを追加したものです