Feat: biyooon, adding using zenohex #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s-hosoai
reviewed
Dec 19, 2024
s-hosoai
approved these changes
Dec 24, 2024
added 3 commits
December 25, 2024 21:13
There was a problem hiding this comment.
@fomfom 全般的にコメントの書き方が不安定な印象なので修正してもらいたいです
https://qiita.com/jnchito/items/f0d90af4ed44b7484103
lib/giocci_engine_zenoh.ex
Outdated
| @doc """ | ||
| 最初に指定されたRelayノードとのZenohコネクションを作成する | ||
| """ | ||
|
|
There was a problem hiding this comment.
@docがどこにかかってるか分かりづらいので改行のけましょう（他にも多数）
@doc """
docdocdoc...
"""
def hoge() do
:hoge
end
lib/giocci_engine_zenoh.ex
Outdated
| engine_name = Application.get_env(:giocci_engine_zenoh, :system_variables)[:my_node_name] | ||
|
|
||
| {:ok, session} = Zenohex.open() | ||
| ## pub,subそれぞれのキーをたてる |
There was a problem hiding this comment.
@fomfom どこの処理に対するコメントが分かりづらいので修正お願いします
added 2 commits
December 27, 2024 14:25
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
一部の従来の機能に通信部分をZenohでおきかえたverを追加したものです