Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PM-18129 add authenticator illustration for 2fa screen #4763

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dseverns-livefront
Copy link
Collaborator

@dseverns-livefront dseverns-livefront commented Feb 21, 2025

🎟️ Tracking

PM-18129

📔 Objective

  • Adds illustration for the Authenticator on the 2fa screen.
  • Corrects some logic so only the Yubi key image is below the description (prior to this change there was only 2 images so just flipped the boolean a bit to make it work generically).
  • Updates image size to match figma for email and authenticator images on that screen.

📸 Screenshots

image

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details4f1bfd8c-7e2a-446c-bddd-fcf48c05b1ec

Great job, no security vulnerabilities found in this Pull Request

Copy link

codecov bot commented Feb 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.30%. Comparing base (892f817) to head (6f4b74d).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4763      +/-   ##
==========================================
- Coverage   89.30%   89.30%   -0.01%     
==========================================
  Files         494      494              
  Lines       41727    41728       +1     
  Branches     5928     5928              
==========================================
  Hits        37266    37266              
- Misses       2411     2412       +1     
  Partials     2050     2050              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants