simplify and harmonize NextSet and NextSetMany #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merging. This will be part of the next release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, please see the following patchset, it is better readable code for NextSet and NextSetMany. They are two very similar functions, but the code was very different in the naming of the variables and lacked any comment. Before refactoring, I wrote a test for NextSetMany, which was still missing in the tests. Take a look at it, if you like it then merge it, if you want me to improve it somehow then write it and if you discard the PR completely that is your decision alone.
Thanks for bitset!
(edited) ah sorry, my gopls gofumpt'd the test and benchmark different than the original (old?) formatting. Shall I reformat to the old style?