-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix event listener conflicts #412
Fix event listener conflicts #412
Conversation
Becase as written in https://reactnative.dev/docs/native-components-ios#events all RCTBubblingEventBlock must be prefixed with on.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Android side looks fine!
Have you also done some manual expectation of the sample apps on iOS and android? :)
Do all of them still work?
Yes 👍 , I tested all the samples apart from casting and offline |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good!
Manual testing looks good as well!
Please delete the testing related branches once merging this!
Co-authored-by: Roland Kákonyi <roland.kakonyi@bitmovin.com>
Sure, I will 👍 |
Description
The names we are using for events are too generic (eg.
onSeek
): this may cause conflicts with other 3rd party libraries in case both are included in the same project.Changes
onBmp
prefix instead of the genericon
prefixevents.ts
namednativeEvents.ts
which contains the bubbled event listenersTesting
Run integration tests to check if events are working correctly
Checklist
CHANGELOG
entry