Add SRT (SubRip) subtitle support #388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rolandkakonyi
changed the base branch from
development
to
update_ios_player_to_3.55.0
strangesource
approved these changes
Jan 26, 2024
| @@ -530,7 +530,12 @@ fun ReadableMap.toSubtitleTrack(): SubtitleTrack? { | |||
| /** | |||
| * Converts any subtitle format name in its mime type representation. | |||
| */ | |||
| private fun String.toSubtitleMimeType(): String = "text/$this" | |||
| private fun String.toSubtitleMimeType(): String = when (this) { | |||
| "vtt" -> "text/vtt" | |||
There was a problem hiding this comment.
not needed, same as the else branch, right?
There was a problem hiding this comment.
True, fixed in cc2198e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for SubRip (SRT) subtitle support for side-loaded subtitles.
In #387 the build broke due to the iOS Player update changes with new enum values.
Changes
Added support for SRT subtitles by mapping the relevant enum cases and mime types accordingly.
Checklist
CHANGELOGentry