Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boost install workaround #372

Merged
merged 4 commits into from
Jan 9, 2024
Merged

boost install workaround #372

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
081e1a6
Add patch files to workaround boost checksum issue (see https://githu…
dweinber Jan 9, 2024
e9c7673
Apply patch files automatically after installing npm/yarn dependencie…
dweinber Jan 9, 2024
7ee7b2f
Update lock files
dweinber Jan 9, 2024
332a46d
Add `patch-package` devDependency to all package.json files
dweinber Jan 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions example/ios/Podfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -689,7 +689,7 @@ SPEC CHECKSUMS:
BitmovinAnalyticsCollector: d9a7ececfdd6936f6e94d30b037cf9ee3b171c70
BitmovinPlayer: 165695cb778ba1940bf2721f70bdc1eaa5115a52
BitmovinPlayerCore: c3f9569ec598c555e69626407cf8e3f2265b6109
boost: 0ed1b9a58a27b2f7885dc9f279bc3b341f44512b
boost: 43f331345fd5d44b60bf621e7e579ae7b8fda687
CocoaAsyncSocket: 065fd1e645c7abab64f7a6a2007a48038fdc6a99
DoubleConversion: 234abba95e31cc2aada0cf3b97cdb11bc5b90575
FBLazyVector: 58c22987e2cd1eebb2e3bc9f7756d87b14c32d3c
Expand Down Expand Up @@ -751,6 +751,6 @@ SPEC CHECKSUMS:
Yoga: f67f5769ce78049c5fe798bc735f04535c7bc1ac
YogaKit: f782866e155069a2cca2517aafea43200b01fd5a

PODFILE CHECKSUM: 531b9f7c2ff19d5c33a14e9a441a3d3d22007a25
PODFILE CHECKSUM: 9bcb40f1d3c1dd409afb56a91db20d32f4c8f9bd

COCOAPODS: 1.14.2
COCOAPODS: 1.14.3
2 changes: 2 additions & 0 deletions example/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
"description": "Example app showcasing bitmovin's RN player SDK",
"version": "0.0.1",
"scripts": {
"postinstall": "patch-package",
"android": "react-native run-android",
"ios": "react-native run-ios",
"start": "react-native start",
Expand Down Expand Up @@ -31,6 +32,7 @@
"@react-native/metro-config": "^0.72.11",
"babel-plugin-module-resolver": "^5.0.0",
"metro-react-native-babel-preset": "0.76.8",
"patch-package": "^8.0.0",
"pod-install": "^0.1.0"
},
"engines": {
Expand Down
15 changes: 15 additions & 0 deletions example/patches/react-native+0.72.6-1.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
diff --git a/node_modules/react-native/third-party-podspecs/boost.podspec b/node_modules/react-native/third-party-podspecs/boost.podspec
index a8286bb..ef12e2a 100644
--- a/node_modules/react-native/third-party-podspecs/boost.podspec
+++ b/node_modules/react-native/third-party-podspecs/boost.podspec
@@ -10,7 +10,9 @@ Pod::Spec.new do |spec|
spec.homepage = 'http://www.boost.org'
spec.summary = 'Boost provides free peer-reviewed portable C++ source libraries.'
spec.authors = 'Rene Rivera'
- spec.source = { :http => 'https://boostorg.jfrog.io/artifactory/main/release/1.76.0/source/boost_1_76_0.tar.bz2',
+ # Patched due to issue https://github.com/boostorg/boost/issues/843
+ # See also https://github.com/facebook/react-native/issues/42180
+ spec.source = { :http => 'https://archives.boost.io/release/1.76.0/source/boost_1_76_0.tar.bz2',
:sha256 => 'f0397ba6e982c4450f27bf32a2a83292aba035b827a5623a14636ea583318c41' }

# Pinning to the same version as React.podspec.
194 changes: 191 additions & 3 deletions example/yarn.lock
View file
Open in desktop

Large diffs are not rendered by default.

28 changes: 14 additions & 14 deletions integration_test/ios/Podfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
PODS:
- BitmovinAnalyticsCollector/BitmovinPlayer (3.3.0):
- BitmovinAnalyticsCollector/BitmovinPlayer (3.3.1):
- BitmovinAnalyticsCollector/Core
- BitmovinPlayerCore (~> 3.48)
- BitmovinAnalyticsCollector/Core (3.3.0)
- BitmovinPlayer (3.49.0):
- BitmovinAnalyticsCollector/Core (3.3.1)
- BitmovinPlayer (3.51.0):
- BitmovinAnalyticsCollector/BitmovinPlayer (~> 3.0)
- BitmovinPlayerCore (= 3.49.0)
- BitmovinPlayerCore (3.49.0)
- BitmovinPlayerCore (= 3.51.0)
- BitmovinPlayerCore (3.51.0)
- boost (1.76.0)
- CocoaAsyncSocket (7.6.5)
- DoubleConversion (1.1.6)
Expand Down Expand Up @@ -472,8 +472,8 @@ PODS:
- React-jsi (= 0.72.6-1)
- React-logger (= 0.72.6-1)
- React-perflogger (= 0.72.6-1)
- RNBitmovinPlayer (0.14.2):
- BitmovinPlayer (= 3.49.0)
- RNBitmovinPlayer (0.15.0):
- BitmovinPlayer (= 3.51.0)
- GoogleAds-IMA-iOS-SDK (= 3.18.4)
- GoogleAds-IMA-tvOS-SDK (= 4.8.2)
- React-Core
Expand Down Expand Up @@ -654,10 +654,10 @@ EXTERNAL SOURCES:
:path: "../node_modules/react-native/ReactCommon/yoga"

SPEC CHECKSUMS:
BitmovinAnalyticsCollector: b3bf447e609a87d41e51a7c029cb16a3bcb3404c
BitmovinPlayer: 920ee8a7df47dc09a038a44a36b24b0c31427ad8
BitmovinPlayerCore: 0040c6c171079ae1a1342baab182c7956deaf6d8
boost: 0ed1b9a58a27b2f7885dc9f279bc3b341f44512b
BitmovinAnalyticsCollector: d9a7ececfdd6936f6e94d30b037cf9ee3b171c70
BitmovinPlayer: 165695cb778ba1940bf2721f70bdc1eaa5115a52
BitmovinPlayerCore: c3f9569ec598c555e69626407cf8e3f2265b6109
boost: 43f331345fd5d44b60bf621e7e579ae7b8fda687
CocoaAsyncSocket: 065fd1e645c7abab64f7a6a2007a48038fdc6a99
DoubleConversion: 234abba95e31cc2aada0cf3b97cdb11bc5b90575
FBLazyVector: 58c22987e2cd1eebb2e3bc9f7756d87b14c32d3c
Expand Down Expand Up @@ -707,11 +707,11 @@ SPEC CHECKSUMS:
React-runtimescheduler: acd6b708338a975a9bb4c594eac0f018f5c15fa3
React-utils: c1cf85c0cd58c11dfb95104a78c608e95d03eb9e
ReactCommon: 1dabb8f37c44d8c7370238bd8f504cbad0cfd941
RNBitmovinPlayer: 020d9bcad225ddee065212cbba660673e456f391
RNBitmovinPlayer: c3ac230f627668dc6374f4138178137acaa64e00
SocketRocket: f32cd54efbe0f095c4d7594881e52619cfe80b17
Yoga: f67f5769ce78049c5fe798bc735f04535c7bc1ac
YogaKit: f782866e155069a2cca2517aafea43200b01fd5a

PODFILE CHECKSUM: a697b54562cb6063433ce9a20f9875a08a45b453
PODFILE CHECKSUM: d0a62a1438d35d60f8a37ab38f3c92b4125f720f

COCOAPODS: 1.14.2
COCOAPODS: 1.14.3
2 changes: 2 additions & 0 deletions integration_test/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
"version": "0.0.1",
"private": true,
"scripts": {
"postinstall": "patch-package",
"android": "react-native run-android",
"ios": "react-native run-ios",
"start": "react-native start",
Expand Down Expand Up @@ -30,6 +31,7 @@
"babel-plugin-module-resolver": "^5.0.0",
"cavy-cli": "^3.0.0",
"metro-react-native-babel-preset": "0.76.8",
"patch-package": "^8.0.0",
"pod-install": "^0.1.39",
"react-native-uuid": "^2.0.1"
},
Expand Down
15 changes: 15 additions & 0 deletions integration_test/patches/react-native+0.72.6-1.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
diff --git a/node_modules/react-native/third-party-podspecs/boost.podspec b/node_modules/react-native/third-party-podspecs/boost.podspec
index a8286bb..ef12e2a 100644
--- a/node_modules/react-native/third-party-podspecs/boost.podspec
+++ b/node_modules/react-native/third-party-podspecs/boost.podspec
@@ -10,7 +10,9 @@ Pod::Spec.new do |spec|
spec.homepage = 'http://www.boost.org'
spec.summary = 'Boost provides free peer-reviewed portable C++ source libraries.'
spec.authors = 'Rene Rivera'
- spec.source = { :http => 'https://boostorg.jfrog.io/artifactory/main/release/1.76.0/source/boost_1_76_0.tar.bz2',
+ # Patched due to issue https://github.com/boostorg/boost/issues/843
+ # See also https://github.com/facebook/react-native/issues/42180
+ spec.source = { :http => 'https://archives.boost.io/release/1.76.0/source/boost_1_76_0.tar.bz2',
:sha256 => 'f0397ba6e982c4450f27bf32a2a83292aba035b827a5623a14636ea583318c41' }

# Pinning to the same version as React.podspec.
Loading
Loading