Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split CI checks based on technology stack #367

Merged
merged 5 commits into from
Dec 19, 2023
Merged

Split CI checks based on technology stack #367

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
88b9b97
chore: split away typescript related CI checks
rolandkakonyi Dec 19, 2023
94abc19
chore: fix concurrency
rolandkakonyi Dec 19, 2023
3d12055
chore: improve the name of jobs
rolandkakonyi Dec 19, 2023
6bd4918
chore: split away iOS and Android related CI jobs
rolandkakonyi Dec 19, 2023
ac4c784
chore: remove single CI job after split
rolandkakonyi Dec 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
95 changes: 95 additions & 0 deletions .github/workflows/ci-android.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,95 @@
name: CI (Android)

on:
pull_request:
paths:
- '.github/workflows/ci-android.yml'
- 'package.json'
- 'yarn.lock'
- 'android/**'
- 'example/android/**'
- 'example/package.json'
- 'example/yarn.lock'

push:
branches: [development]
paths:
- '.github/workflows/ci-android.yml'
- 'package.json'
- 'yarn.lock'
- 'android/**'
- 'example/android/**'
- 'example/package.json'
- 'example/yarn.lock'

concurrency:
group: ci-android-${{ github.event.pull_request.number || github.ref }}
cancel-in-progress: true

env:
NO_FLIPPER: 1

jobs:
code-style-android:
name: Code style Android
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v4

- name: Set up Java
uses: actions/setup-java@v3
with:
distribution: 'zulu'
java-version: '11'

- name: Set up Gradle cache
uses: gradle/gradle-build-action@v2
with:
cache-read-only: ${{ github.ref != 'refs/heads/development' }}

- name: Check code style
run: ./gradlew ktlintCheck
working-directory: android

test-build-android:
name: Build Android
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v4

- name: Setup node and npm registry
uses: actions/setup-node@v3
with:
node-version: '16'
registry-url: 'https://registry.npmjs.org/'
cache: 'yarn'

- name: Set up Java
uses: actions/setup-java@v3
with:
distribution: 'zulu'
java-version: '11'

- name: Install node_modules
run: yarn install --frozen-lockfile

- name: Install node_modules (example/)
run: yarn install --frozen-lockfile --cwd example

- name: Install node_modules (integration_test/)
run: yarn install --frozen-lockfile --cwd integration_test

- name: Set up Gradle cache
uses: gradle/gradle-build-action@v2
with:
cache-read-only: ${{ github.ref != 'refs/heads/development' }}

- name: Build Android example
run: ./gradlew assembleDebug --build-cache
working-directory: example/android

- name: Build Android integration test host app
run: ./gradlew assembleDebug --build-cache
working-directory: integration_test/android
172 changes: 27 additions & 145 deletions .github/workflows/ci.yml → .github/workflows/ci-ios-tvos.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,65 +1,41 @@
name: CI
name: CI (iOS & tvOS)

on:
pull_request:
paths-ignore:
- '**.md'
paths:
- '.github/workflows/ci-ios-tvos.yml'
- 'package.json'
- 'yarn.lock'
- 'ios/**'
- 'RNBitmovinPlayer.podspec'
- '.swiftlint.yml'
- 'Brewfile.lock.json'
- 'example/ios/**'
- 'example/package.json'
- 'example/yarn.lock'

push:
branches: [development]
paths-ignore:
- '**.md'
paths:
- '.github/workflows/ci-ios-tvos.yml'
- 'package.json'
- 'yarn.lock'
- 'ios/**'
- 'RNBitmovinPlayer.podspec'
- '.swiftlint.yml'
- 'Brewfile.lock.json'
- 'example/ios/**'
- 'example/package.json'
- 'example/yarn.lock'

concurrency:
group: ci-${{ github.event.pull_request.number || github.ref }}
group: ci-ios-tvos-${{ github.event.pull_request.number || github.ref }}
cancel-in-progress: true

env:
NO_FLIPPER: 1

jobs:
code-style-typescript:
name: Code style Typescript
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v4

- name: Setup node and npm registry
uses: actions/setup-node@v3
with:
node-version: '16'
registry-url: 'https://registry.npmjs.org/'
cache: 'yarn'

- name: Install node_modules
run: yarn install --frozen-lockfile

- name: Lint Typescript
run: yarn lint

code-style-android:
name: Code style Android
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v4

- name: Set up Java
uses: actions/setup-java@v3
with:
distribution: 'zulu'
java-version: '11'

- name: Set up Gradle cache
uses: gradle/gradle-build-action@v2
with:
cache-read-only: ${{ github.ref != 'refs/heads/development' }}

- name: Check code style
run: ./gradlew ktlintCheck
working-directory: android

code-style-ios:
name: Code style iOS
runs-on: macOS-latest
Expand All @@ -69,108 +45,14 @@ jobs:

- uses: maxim-lobanov/setup-xcode@v1
with:
xcode-version: '14.1'
xcode-version: '14.2'

- name: Install dependencies
run: brew bundle install

- name: Check code style
run: swiftlint --strict

test-build-typescript:
name: Build Typescript
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v4

- name: Setup node and npm registry
uses: actions/setup-node@v3
with:
node-version: '16'
registry-url: 'https://registry.npmjs.org/'
cache: 'yarn'

- name: Install node_modules
run: yarn install --frozen-lockfile

- name: Install node_modules (example/)
run: yarn install --frozen-lockfile --cwd example

- name: Install node_modules (integration_test/)
run: yarn install --frozen-lockfile --cwd integration_test

- name: Compile TypeScript
run: yarn typescript

test-build-docs:
name: Build API docs
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v4

- name: Setup node and npm registry
uses: actions/setup-node@v3
with:
node-version: '16'
registry-url: 'https://registry.npmjs.org/'
cache: 'yarn'

- name: Install node_modules
run: yarn install --frozen-lockfile

- name: Install node_modules (example/)
run: yarn install --frozen-lockfile --cwd example

- name: Install node_modules (integration_test/)
run: yarn install --frozen-lockfile --cwd integration_test

- name: Build docs
run: yarn docs

test-build-android:
name: Build Android
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v4

- name: Setup node and npm registry
uses: actions/setup-node@v3
with:
node-version: '16'
registry-url: 'https://registry.npmjs.org/'
cache: 'yarn'

- name: Set up Java
uses: actions/setup-java@v3
with:
distribution: 'zulu'
java-version: '11'

- name: Install node_modules
run: yarn install --frozen-lockfile

- name: Install node_modules (example/)
run: yarn install --frozen-lockfile --cwd example

- name: Install node_modules (integration_test/)
run: yarn install --frozen-lockfile --cwd integration_test

- name: Set up Gradle cache
uses: gradle/gradle-build-action@v2
with:
cache-read-only: ${{ github.ref != 'refs/heads/development' }}

- name: Build Android example
run: ./gradlew assembleDebug --build-cache
working-directory: example/android

- name: Build Android integration test host app
run: ./gradlew assembleDebug --build-cache
working-directory: integration_test/android

test-build-ios:
name: Build iOS
runs-on: macOS-12
Expand All @@ -187,7 +69,7 @@ jobs:

- uses: maxim-lobanov/setup-xcode@v1
with:
xcode-version: '14.1'
xcode-version: '14.2'

- name: Install node_modules
run: yarn install --frozen-lockfile
Expand Down Expand Up @@ -257,7 +139,7 @@ jobs:

- uses: maxim-lobanov/setup-xcode@v1
with:
xcode-version: '14.1'
xcode-version: '14.2'

- name: Install node_modules
run: yarn install --frozen-lockfile
Expand Down
Loading