[MRG] Add sqlserver database adapter #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joaquingx
changed the title
joaquingx
force-pushed
the
add-azuresql-database-adapter
branch
from
9b2d75e to
06d3410
Compare
joaquingx
changed the title
mgonnav
reviewed
Jan 31, 2024
|
|
||
| def __init__(self, connection_string, production, certificate_path): | ||
| self.connection_string = connection_string | ||
| self.local_storage = threading.local() |
There was a problem hiding this comment.
The production and certificate_path variables are not being used here, although they may be required for some production environments. Or are these parameters also included in the connection string if needed?
There was a problem hiding this comment.
I have been reviewing the Azure SQL documentation and it appears that using a certificate path is not a requirement, even for production environments.
| return InsertionResponse(response, ex) | ||
|
|
||
| def insert_one_to_unique_dataset(self, database_name, table_name, item): # Needs more discussion. | ||
| return self.insert_one_to_dataset(database_name, table_name, item) |
There was a problem hiding this comment.
@joaquingx In what sense does this require more discussion?
There was a problem hiding this comment.
It appears that this function is not being utilized as intended. We will need to discuss to address the appropriate use of this function in future implementations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the changes, relevant motivation and context.
Issue
Checklist before requesting a review