Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow in-flight disarming via controller without triggering emergency stop #730

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

gemenerik
Copy link
Member

@gemenerik gemenerik commented Oct 21, 2024

This PR updates the client to allow users controlling their drones with physical controllers to disarm the drone mid-flight. Previously, the disarm button on controllers was explicitly linked to triggering an emergency stop, preventing standard disarming during flight.

With this change, pressing the disarm button on the controller will now safely disarm the drone, rather than activating an emergency stop. For emergency situations, users should continue using the dedicated emergency stop function, which is more reliable for halting the drone immediately.

The (dis)arm controller button is still linked to crash recovery when relevant.

UI arm/recover/emergency-stop button behavior is unchanged.

Use together with bitcraze/crazyflie-firmware#1426

@gemenerik gemenerik requested a review from tobbeanton October 21, 2024 14:38
Copy link
Member

@tobbeanton tobbeanton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

… stop

This commit updates the client to allow users controlling their drones with physical controllers to disarm the drone mid-flight. Previously, the disarm button on controllers was explicitly linked to triggering an emergency stop, preventing standard disarming during flight.

With this change, pressing the disarm button on the controller will now safely disarm the drone, rather than activating an emergency stop. For emergency situations, users should continue using the dedicated emergency stop function, which is more reliable for halting the drone immediately.

The (dis)arm controller button is still linked to crash recovery.

UI arm/recover/emergency-stop button behavior is unchanged.

Use together with bitcraze/crazyflie-firmware#1426
@gemenerik gemenerik merged commit 002fd0a into master Oct 21, 2024
1 check passed
@gemenerik gemenerik deleted the rik/disarming branch October 30, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants