Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support categorized default logging configurations, introduce PID tuning logging configurations #716

Merged
merged 4 commits into from
Jun 20, 2024

Conversation

gemenerik
Copy link
Member

@gemenerik gemenerik commented Jun 19, 2024

  • Support categorized default logging configurations, rather than only a "Default" category.
  • Introduce default PID tuning logging configurations. Mainly for plotting reasons.
    • Both in split (e.g. pitch, roll yaw) and combined (e.g. attitude) categories. I found that I was switching between the two depending on how detailed the tuning was. I'm open to other people's opinions on this.

Copy link
Member

@tobbeanton tobbeanton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I don't have anything to object but I have one question, could the spaces in the directories cause any problem?

@gemenerik
Copy link
Member Author

Nice! I don't have anything to object but I have one question, could the spaces in the directories cause any problem?

I used whitespace since our GUI directly displays these names - as far as I know without issues. However, I recognize that whitespace can lead to problems, so to be safe I have replaced them with underscores.

Note that nothing prohibits users from creating folder and file names with whitespace. From the GUI, it may not be immediately apparent that this is directly represented by directories and files. Perhaps this is something to enforce?

@gemenerik gemenerik merged commit 9f8ae49 into master Jun 20, 2024
1 check passed
@gemenerik gemenerik deleted the rik/pidconfigs branch June 20, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants