Show supervisor info #682
Merged
Show supervisor info #682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knmcguire
reviewed
Oct 16, 2023
src/cfclient/ui/tabs/FlightTab.py
Outdated
| self._supervisor_state.setText("Tumbled") | ||
|
|
||
| if self._is_locked(): | ||
| self._supervisor_state.setText("Locked - reboot") |
There was a problem hiding this comment.
I tried this and the wording was a bit confusing. as it sseemed like it was locked and then was going to reboot by itself. It doesn't incite an action.
Perhaps 'Locked - please reboot' or someting?
There was a problem hiding this comment.
Good point!
The space is limited though, the best I can come up with that fits is "Locked-pls reboot"
There was a problem hiding this comment.
I like the please part but perhaps something like "Locked -> reboot" looks better? That is not so clear that an action is needed though.
|
Requires bitcraze/crazyflie-firmware#1326 |
knmcguire
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a field in the flight tab that indicates the state of the supervisor. If the Crazyflie is locked the color of the field is red to clearly show why flight is not possible