Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on bitcoin-ffi #673

Conversation

thunderbiscuit
Copy link
Member

@thunderbiscuit thunderbiscuit commented Feb 18, 2025

This PR, one commit at a time, brings the external types from bitcoin-ffi 0.1.2 back into our own bitcoin.rs source file.

WIP.

It builds on #672, so must be merge after.

Description

Notes to the reviewers

Changelog notice

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

New Features:

  • I've added tests for the new feature
  • I've added docs for the new feature

Bugfixes:

  • This pull request breaks the existing API
  • I've added tests to reproduce the issue which are now passing
  • I'm linking the issue being fixed by this PR

@thunderbiscuit thunderbiscuit force-pushed the feat/remove-bitcoin-ffi branch 2 times, most recently from dacc94c to 14ce085 Compare February 18, 2025 20:39
@thunderbiscuit thunderbiscuit force-pushed the feat/remove-bitcoin-ffi branch 2 times, most recently from 1bd6c2c to 3139b56 Compare February 19, 2025 16:59
@thunderbiscuit thunderbiscuit force-pushed the feat/remove-bitcoin-ffi branch from 3139b56 to 3373196 Compare February 19, 2025 18:51
@thunderbiscuit thunderbiscuit mentioned this pull request Feb 19, 2025
8 tasks
@thunderbiscuit
Copy link
Member Author

I'm not sure why this PR on GitHub keeps the commits from #672, but it makes it messy to review. Replacing with #674.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant