Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare language bindings libraries for beta 7 release #653

Merged
merged 2 commits into from
Jan 22, 2025
Merged

Prepare language bindings libraries for beta 7 release #653

merged 2 commits into from
Jan 22, 2025

Conversation

reez
Copy link
Collaborator

@reez reez commented Jan 21, 2025 •
edited
Loading

Description

This PR:

  1. Fixes the live Python tests by updating them for the new full_scan argument naming convention.
  2. Bumps the (unused) version of the library in the Cargo.toml file to beta 7 (sorry had not bumped since alpha 11!).

Notes to the reviewers

Did not bump bdk version because we were already on 1.0.0.

Changelog notice

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

New Features:

  • I've added tests for the new feature
  • I've added docs for the new feature

Bugfixes:

  • This pull request breaks the existing API
  • I've added tests to reproduce the issue which are now passing
  • I'm linking the issue being fixed by this PR

@reez reez marked this pull request as ready for review January 21, 2025 23:26
@reez reez requested a review from thunderbiscuit January 21, 2025 23:29
thunderbiscuit
thunderbiscuit approved these changes Jan 22, 2025
View reviewed changes
Copy link
Member

@thunderbiscuit thunderbiscuit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK b5bf3b7. Thanks for fixing the Python tests! I noticed they had failed on the Sunday run.

@reez reez merged commit b5bf3b7 into bitcoindevkit:master Jan 22, 2025
25 checks passed
@reez reez deleted the prep-beta7 branch January 22, 2025 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thunderbiscuit thunderbiscuit thunderbiscuit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@reez @thunderbiscuit