Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fixes to Electrum and Esplora APIs #642

Merged

Conversation

thunderbiscuit
Copy link
Member

@thunderbiscuit thunderbiscuit commented Dec 18, 2024

This PR cleans up some of the method and argument names we had not mirrored correctly from the Rust side.

  • full_scan_request -> request docs
  • sync_request -> request docs
  • (Electrum) broadcast -> transaction_broadcast docs

Changelog notice

Changed:
  - The full_scan and sync methods on the Electrum and Esplora clients now take a renamed `request` argument [#642]
  - ElectrumClient::broacast was renamed ElectrumClient::transaction_broadcast to mirror the Rust API [#642]

[#642]: https://github.com/bitcoindevkit/bdk-ffi/pull/642

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

New Features:

  • I've added tests for the new feature
  • I've added docs for the new feature

@reez
Copy link
Collaborator

reez commented Jan 6, 2025

ACK 315c379

Let me know if need another ack after rebase on #641 once merged or anything

Love these kinds of PR's, shows people we are on top of things and not letting stale naming slip by for too long.

@thunderbiscuit
Copy link
Member Author

Yeah it actually has your ACK but not the "approved" in the GitHub UI, so I can't merge. But also the tests appear to be blocked...

@reez
Copy link
Collaborator

reez commented Jan 6, 2025

Bah! just "approved" so should be unblocked for that part now

@thunderbiscuit thunderbiscuit merged commit 4960119 into bitcoindevkit:master Jan 6, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants