Skip to content

Commit

Permalink
of-dpa: don't notify about bridging flows being deleted
Browse files Browse the repository at this point in the history
controller::handle_bridging_table_rm() will be called for various
reasons, but we actually only care for one, the idle timeout.

Especially we don't care about flows being removed which we
intentionally deleted, so ignore any that aren't idle timeouts.

Fixes: 291591d ("l2 aging added")
Signed-off-by: Jonas Gorski <jonas.gorski@bisdn.de>
  • Loading branch information
KanjiMonster committed Aug 9, 2024
1 parent 17b0a2b commit 4c65865
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions src/of-dpa/controller.cc
Original file line number Diff line number Diff line change
Expand Up @@ -446,6 +446,10 @@ void controller::handle_bridging_table_rm(
rofl::caddress_ll eth_dst;
uint16_t vid = 0;

// we only care about flows being timed out
if (msg.get_reason() != rofl::openflow13::OFPRR_IDLE_TIMEOUT)
return;

try {
eth_dst = msg.get_match().get_eth_dst();
vid = msg.get_match().get_vlan_vid() & 0xfff;
Expand Down

0 comments on commit 4c65865

Please sign in to comment.