Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed duplicates from variable allowed_values #320

Merged
merged 3 commits into from
Nov 9, 2023

Conversation

perronld
Copy link
Contributor

@perronld perronld commented Nov 8, 2023

Overview

This PR fixes combability issue with Weaver/CWL

Changes:

  • Removed duplicates from variables allowed_values

Verified

This commit was signed with the committer’s verified signature.
m8rmclaren Hayden
@perronld perronld requested a review from Zeitsperre November 8, 2023 01:14
Copy link
Collaborator

@Zeitsperre Zeitsperre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This issue has popped up in a few places. Are there any ways to make the order/duplicate values less important?

@perronld
Copy link
Contributor Author

perronld commented Nov 9, 2023

It's the exact same problem as #301 during the WPS to CWL conversion.

@perronld perronld merged commit b8dbec2 into master Nov 9, 2023
@perronld perronld deleted the variable-duplicates branch November 9, 2023 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants