Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add thredds to docker-compose as DAP server #99

Merged
merged 3 commits into from
Feb 13, 2020
Merged

Add thredds to docker-compose as DAP server #99

merged 3 commits into from
Feb 13, 2020

Conversation

tlvu
Copy link
Contributor

@tlvu tlvu commented Feb 12, 2020 •
edited
Loading

Overview

This PR fixes #98

Changes:

  • Added Thredds docker image to run along side Emu docker image
  • The outputpath of Emu is shown as Thredds catalog

Related Issue / Discussion

Additional Information

Test notebook calling emu.multiple_outputs() and emu.output_formats(): https://gist.github.com/tlvu/ac20f7f864585156ba6635e3d4792b2f

Thredds corresponding screenshot:

2020-02-12-154705_1143x452_scrot

2020-02-12-154717_1145x317_scrot

2020-02-12-154729_1144x586_scrot

2020-02-12-154742_1138x721_scrot

2020-02-12-154805_1143x314_scrot

@tlvu tlvu requested review from huard and cehbrecht February 12, 2020 20:59
cehbrecht
cehbrecht approved these changes Feb 13, 2020
View reviewed changes
Copy link
Member

@cehbrecht cehbrecht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@cehbrecht
Copy link
Member

@tlvu feel free to merge.

@cehbrecht cehbrecht added this to the 1.0.0 milestone Feb 13, 2020
@huard
Copy link
Contributor

huard commented Feb 13, 2020

@tlvu This is so nice ! Works like a charm. Thanks !

@huard huard merged commit 875ffab into bird-house:master Feb 13, 2020
@tlvu tlvu deleted the add-thredds-to-docker-compose branch June 2, 2020 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huard huard huard approved these changes

@cehbrecht cehbrecht cehbrecht approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.

DAP server running in parallel with Emu
3 participants
@tlvu @cehbrecht @huard