Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change from pymodbus.client to pymodbusTCP.client #39

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Change from pymodbus.client to pymodbusTCP.client #39

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
eb09a33
Change from pymodbus.client to pymodbusTCP.client
nerfherder Sep 14, 2021
09a7165
merge upstream
nerfherder Oct 12, 2021
bf9fe91
merge upstream
nerfherder Oct 16, 2021
b1c596c
Merge branch 'binsentsu-master' into nerfherder-patch-pyModbusTCP
nerfherder Oct 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
merge upstream
  • Loading branch information
@nerfherder
nerfherder committed Oct 12, 2021
commit 09a71653646a4076584799d5db6e01347315748b
5 changes: 3 additions & 2 deletions custom_components/solaredge_modbus/__init__.py
View file
Original file line number Diff line number Diff line change
@@ -722,9 +722,9 @@ def read_modbus_data_battery2(self):
def read_modbus_data_battery(self, battery_prefix, start_address):
if not battery_prefix + "attrs" in self.data:
battery_data = self.read_holding_registers(address=start_address, count=0x4C)
if not battery_data.isError():
if battery_data:
decoder = BinaryPayloadDecoder.fromRegisters(
battery_data.registers, byteorder=Endian.Big,wordorder=Endian.Little
battery_data, byteorder=Endian.Big,wordorder=Endian.Little
)

def decode_string(decoder):
@@ -769,6 +769,7 @@ def decode_string(decoder):

self.data[battery_prefix + "attrs"] = battery_info


storage_data = self.read_holding_registers(address=start_address + 0x6C, count=28)
if storage_data:
decoder = BinaryPayloadDecoder.fromRegisters(