Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix embedded python datetime parsing #697

Merged
merged 1 commit into from
Dec 1, 2024
Merged

Fix embedded python datetime parsing #697

merged 1 commit into from
Dec 1, 2024

Conversation

rikroe
Copy link
Member

@rikroe rikroe commented Nov 30, 2024

Proposed change

Allow running on some embedded Pythons again. cpython issue is only fixed in Python>=3.12.

This partly reverts commit 91c26e8

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to this library)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works.

@rikroe
Revert datetime parsing to time.time
3610213 
This partly reverts commit 91c26e8
@rikroe rikroe mentioned this pull request Nov 30, 2024
Closed
5 tasks
FilipDem
FilipDem approved these changes Nov 30, 2024
View reviewed changes
Copy link

@FilipDem FilipDem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works now in embedded python!

@rikroe rikroe merged commit e3617d4 into bimmerconnected:master Dec 1, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FilipDem FilipDem FilipDem approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Python bug with strptime
2 participants
@rikroe @FilipDem