Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Documentation for captcha #680

Merged
merged 4 commits into from
Nov 24, 2024
Merged

Conversation

rikroe
Copy link
Member

@rikroe rikroe commented Nov 23, 2024

Proposed change

Improves docs from feedback in discussions.

@gerard33 please check and let me know if you feel somethings missing.

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to this library)
  • Breaking change (fix/feature causing existing functionality to break)
  • [s] Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:

Checklist

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works.

@rikroe rikroe requested a review from gerard33 November 23, 2024 17:08
@rikroe
Copy link
Member Author

rikroe commented Nov 24, 2024

Merging this now to improve docs quickly - any feedback is still appreciated and we just do another PR.

@rikroe rikroe merged commit 81a1da6 into bimmerconnected:master Nov 24, 2024
11 checks passed
@gerard33
Copy link
Member

LGTM. I don't have any feedback at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants