Allow tire target pressure to be empty (#531)

* Update pre-commit * Don't fail if no target pressure
bimmerconnected · May 5, 2023 · bd6e0f1 · bd6e0f1
1 parent 09d2774
commit bd6e0f1
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 9 deletions.
diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
@@ -1,20 +1,20 @@
 repos:
   - repo: https://github.com/charliermarsh/ruff-pre-commit
-    rev: v0.0.251
+    rev: v0.0.265
     hooks:
       - id: ruff
         args:
           - --fix
   - repo: https://github.com/psf/black
-    rev: 23.1.0
+    rev: 23.3.0
     hooks:
       - id: black
         args:
           - --safe
           - --quiet
         files: ^((bimmer_connected|test)/.+)?[^/]+\.py$
   - repo: https://github.com/codespell-project/codespell
-    rev: v2.2.2
+    rev: v2.2.4
     hooks:
       - id: codespell
         args:
@@ -24,7 +24,7 @@ repos:
         exclude_types: [csv, json]
         exclude: ^test/responses/
   - repo: https://github.com/pre-commit/mirrors-mypy
-    rev: v1.0.1
+    rev: v1.2.0
     hooks: 
       - id: mypy
         name: mypy

diff --git a/bimmer_connected/vehicle/tires.py b/bimmer_connected/vehicle/tires.py
@@ -13,7 +13,7 @@ class TireState:
 
     def __init__(self, status: Dict, details: Optional[Dict] = None):
         self.current_pressure: int = status["currentPressure"]
-        self.target_pressure: int = status["targetPressure"]
+        self.target_pressure: Optional[int] = status.get("targetPressure")
         self.season: Optional[int] = None
         self.manufacturing_week: Optional[datetime] = None
 

diff --git a/test/responses/G20/bmw-eadrax-vcs_v4_vehicles_state_WBA00000000DEMO03.json b/test/responses/G20/bmw-eadrax-vcs_v4_vehicles_state_WBA00000000DEMO03.json
@@ -199,7 +199,6 @@
                 "status": {
                     "currentPressure": 241,
                     "pressureStatus": 0,
-                    "targetPressure": 269,
                     "wearStatus": 0
                 }
             },
@@ -221,7 +220,6 @@
                 "status": {
                     "currentPressure": 255,
                     "pressureStatus": 0,
-                    "targetPressure": 269,
                     "wearStatus": 0
                 }
             },
@@ -243,7 +241,6 @@
                 "status": {
                     "currentPressure": 324,
                     "pressureStatus": 0,
-                    "targetPressure": 303,
                     "wearStatus": 0
                 }
             },
@@ -265,7 +262,6 @@
                 "status": {
                     "currentPressure": 331,
                     "pressureStatus": 0,
-                    "targetPressure": 303,
                     "wearStatus": 0
                 }
             }

diff --git a/test/test_vehicle_status.py b/test/test_vehicle_status.py
@@ -484,6 +484,13 @@ async def test_tires():
     assert tires.front_left.manufacturing_week is None
     assert tires.front_left.season is None
 
+    # Vehicle with current tire pressure and details, but no target pressure
+    tires = account.get_vehicle(VIN_G20).tires
+    assert tires.front_left.current_pressure == 241
+    assert tires.front_left.target_pressure is None
+    assert tires.front_left.manufacturing_week == datetime.datetime(2021, 10, 4, 0, 0)
+    assert tires.front_left.season == 2
+
     # Vehicle with details
     tires = account.get_vehicle(VIN_G70).tires
     assert tires.rear_left.current_pressure == 261