Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

peep command shows EEPROM addresses starting at 0xe000 #21

Open
matthijskooijman opened this issue Jan 28, 2014 · 1 comment
Open

peep command shows EEPROM addresses starting at 0xe000 #21

matthijskooijman opened this issue Jan 28, 2014 · 1 comment

Comments

@matthijskooijman
Copy link

See https://github.com/billroy/bitlash/blob/master/src/bitlash-eeprom.c#L252

This is obviously intentional, but I can't quite figure out where this magical 0xe000 constant comes from. Care to enlighten me?

PS, it seems that the issue tracker might not be the best place for discussions / questions like these. Is there any other forum or mailing list better suited that I missed? Perhaps an IRC channel?

@billroy
Copy link
Owner

billroy commented Jan 28, 2014

You are welcome to email me directly, but the issue tracker preserves the discussion for others to see, so it’s probably best.

That 0xe000 is a kludge. There wasn’t room to add a way to print right-justified text when the eeprom code was written (for the ‘168), but the eeprom map looked ugly with the addresses coming out variable length. Adding the constant simply makes the printout columns come out right.

This could certainly be improved now that there is more space.

-br

On Jan 28, 2014, at 2:40 AM, Matthijs Kooijman notifications@github.com wrote:

See https://github.com/billroy/bitlash/blob/master/src/bitlash-eeprom.c#L252

This is obviously intentional, but I can't quite figure out where this magical 0xe000 constant comes from. Care to enlighten me?

PS, it seems that the issue tracker might not be the best place for discussions / questions like these. Is there any other forum or mailing list better suited that I missed? Perhaps an IRC channel?


Reply to this email directly or view it on GitHub.

patthoyts added a commit to patthoyts/bitlash that referenced this issue Dec 31, 2014
…tput

A constant offset of 0xe000 was added purely to assist in formatting the
addresses which can be replaced by reusing the printIntegerInBase function.

Signed-off-by: Pat Thoyts <patthoyts@users.sourceforge.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants