Do not create "[STUDYID]-NA" USUBJID values

billdenney · Sep 13, 2021 · 1f3f033 · 1f3f033
1 parent b16a1a7
commit 1f3f033
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 2 deletions.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -1,6 +1,6 @@
 Package: Rsdtm
 Title: Study Data Tabulation Model (SDTM) import, export, and management assistance
-Version: 0.0.0.9012
+Version: 0.0.0.9013
 Authors@R:
   c(
     person("William", "Denney", email = "wdenney@humanpredictions.com", role = c("aut", "cre")),

diff --git a/R/standardize_ids.R b/R/standardize_ids.R
@@ -49,7 +49,12 @@ standardize_sdtm_id <- function(data, id, studyid, sep_usubjid="-", allow_missin
   }
   if ("SUBJID" %in% names(ret) & !("USUBJID" %in% names(ret))) {
     # Put USUBJID in
-    ret$USUBJID <- paste(ret$STUDYID, ret$SUBJID, sep=sep_usubjid)
+    ret$USUBJID <-
+      ifelse(
+        is.na(ret$SUBJID),
+        NA_character_,
+        paste(ret$STUDYID, ret$SUBJID, sep=sep_usubjid)
+      )
   }
   if ("USUBJID" %in% names(ret) & !("SUBJID" %in% names(ret))) {
     ret$SUBJID <-

diff --git a/tests/testthat/test-standardize_ids.R b/tests/testthat/test-standardize_ids.R
@@ -55,6 +55,14 @@ test_that("standardize_sdtm_id alternate paths", {
     standardize_sdtm_id(data=data.frame(STUDYID="A", SUBJID="B", USUBJID=NA_character_), allow_missing_id=TRUE),
     data.frame(STUDYID="A", USUBJID=NA_character_, SUBJID="B")
   )
+  expect_equal(
+    standardize_sdtm_id(data=data.frame(STUDYID="A", SUBJID="B", USUBJID=NA_character_), allow_missing_id=TRUE),
+    data.frame(STUDYID="A", USUBJID=NA_character_, SUBJID=c("B"))
+  )
+  expect_equal(
+    standardize_sdtm_id(data=data.frame(STUDYID="A", SUBJID=c("B", NA_character_)), allow_missing_id=TRUE),
+    data.frame(STUDYID="A", USUBJID=c("A-B", NA_character_), SUBJID=c("B", NA_character_))
+  )
 })
 
 test_that("standardize_sdtm_id errors", {